Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: hints for using v4 dns to avoid 503 (#2478) #2488

Merged
merged 2 commits into from
Feb 1, 2018
Merged

config: hints for using v4 dns to avoid 503 (#2478) #2488

merged 2 commits into from
Feb 1, 2018

Conversation

winguse
Copy link
Contributor

@winguse winguse commented Jan 31, 2018 •
edited
Loading

Add a YAML comment to the config file that might help someone who encounters v4/v6 dns problem in the future.

Risk Level

Low, fixing sample config

Testing

manual testing.

Environment: a machine don't have ipv6 network but can resolve v6 address of google

before

$ curl -i http://127.0.0.1:10000
HTTP/1.1 503 Service Unavailable
content-length: 57
content-type: text/plain
date: Wed, 31 Jan 2018 03:23:39 GMT
server: envoy

upstream connect error or disconnect/reset before headers

uncomment dns_lookup_family: V4_ONLY

$ curl -i http://127.0.0.1:10000
HTTP/1.1 200 OK
date: Wed, 31 Jan 2018 03:27:02 GMT
expires: -1
cache-control: private, max-age=0
content-type: text/html; charset=ISO-8859-1
...

fix

#2478

@htuch
Copy link
Member

htuch commented Jan 31, 2018

Can you merge master to pickup #2490?

alyssawilk
alyssawilk previously approved these changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending a fresh merge (I'd rather not force-merge anything but other folks are welcome to :-) )

mattklein123
mattklein123 reviewed Jan 31, 2018
View reviewed changes
configs/google_com_proxy.v2.yaml Outdated
@@ -28,6 +28,9 @@ static_resources:
- name: service_google
connect_timeout: 0.25s
type: LOGICAL_DNS
# uncomment the following line if your environment don't have v6 network
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: (As long as you have to merge master):

"Uncomment the following line if your environment doesn't have v6 network access or Envoy may try to talk to a v6 endpoint which will result in a 503 error."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@winguse
fixing the poor English
bd42d42 
Signed-off-by: Yingyu Cheng <[email protected]>
mattklein123
mattklein123 approved these changes Feb 1, 2018
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 6a2781e into envoyproxy:master Feb 1, 2018
@winguse winguse deleted the patch-3 branch February 1, 2018 09:14
Shikugawa pushed a commit to Shikugawa/envoy that referenced this pull request Mar 28, 2020
@geeknoid @istio-testing
Update common files. (envoyproxy#2488)
23e58a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

@alyssawilk alyssawilk alyssawilk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@winguse @htuch @mattklein123 @alyssawilk